Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update theme descriptions and do not strip from style.css files #2401

Merged
merged 3 commits into from
Nov 11, 2024

Conversation

dkoo
Copy link
Contributor

@dkoo dkoo commented Nov 11, 2024

All Submissions:

Changes proposed in this Pull Request:

#2387 introduced minification for built style.css files, but it didn't make the theme description comment blocks important with a /*! prefix for child themes. Without the theme descriptions, release CI jobs fail.

This PR adds the important prefixes to all theme description SCSS, and also updates some outdated description args such as supported WP versions, and removing the AMP tag.

How to test the changes in this Pull Request:

  1. Check out this branch
  2. Run npm run build
  3. In each newspack-*/style.css built file, confirm that the theme description block appears at the top of the file. It should look like this:
@charset "UTF-8";
/*!
Theme Name: Newspack Joseph
Theme URI: https://github.com/Automattic/newspack-theme
Author: Automattic
Author URI: https://newspack.com
Description: The official theme for Newspack, an all-in-one platform that simplifies publishing and drives audience and revenue right out of the box.
Requires at least: 6.6
Tested up to: 6.7
Version: 2.1.0
License: GNU General Public License v2 or later
License URI: http://www.gnu.org/licenses/gpl-2.0.html
Text Domain: newspack-joseph
Tags: Newspack

This theme, like WordPress, is licensed under the GPL.
Use it to make something cool, have fun, and share what you've learned with others.

Newspack Theme is based on Underscores https://underscores.me/, (C) 2012-2018 Automattic, Inc.
Underscores is distributed under the terms of the GNU GPL v2 or later.

Normalizing styles have been helped along thanks to the fine work of
Nicolas Gallagher and Jonathan Neal https://necolas.github.io/normalize.css/
*/

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@dkoo dkoo added the [Status] Needs Review The issue or pull request needs to be reviewed label Nov 11, 2024
@dkoo dkoo self-assigned this Nov 11, 2024
@dkoo dkoo requested a review from a team as a code owner November 11, 2024 21:14
@dkoo dkoo requested a review from laurelfulford November 11, 2024 21:25
Copy link
Contributor

@laurelfulford laurelfulford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good, and running npm run build works & includes the description in the generated files! 🎉

@github-actions github-actions bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Nov 11, 2024
@dkoo dkoo merged commit 28770e0 into trunk Nov 11, 2024
4 checks passed
@dkoo dkoo deleted the fix/theme-descriptions branch November 11, 2024 21:47
Copy link

Hey @dkoo, good job getting this PR merged! 🎉

Now, the needs-changelog label has been added to it.

Please check if this PR needs to be included in the "Upcoming Changes" and "Release Notes" doc. If it doesn't, simply remove the label.

If it does, please add an entry to our shared document, with screenshots and testing instructions if applicable, then remove the label.

Thank you! ❤️

matticbot pushed a commit that referenced this pull request Nov 11, 2024
## [2.1.1-alpha.1](v2.1.0...v2.1.1-alpha.1) (2024-11-11)

### Bug Fixes

* merge pull request [#2398](#2398) from Automattic/trunk ([dc50674](dc50674))
* update theme descriptions and do not strip from style.css files ([#2401](#2401)) ([28770e0](28770e0))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 2.1.1-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Nov 11, 2024
## [2.1.1](v2.1.0...v2.1.1) (2024-11-11)

### Bug Fixes

* merge pull request [#2398](#2398) from Automattic/trunk ([dc50674](dc50674))
* update theme descriptions and do not strip from style.css files ([#2401](#2401)) ([28770e0](28770e0))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 2.1.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released on @alpha released [Status] Approved The pull request has been reviewed and is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants