-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update theme descriptions and do not strip from style.css files #2401
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good, and running npm run build
works & includes the description in the generated files! 🎉
Hey @dkoo, good job getting this PR merged! 🎉 Now, the Please check if this PR needs to be included in the "Upcoming Changes" and "Release Notes" doc. If it doesn't, simply remove the label. If it does, please add an entry to our shared document, with screenshots and testing instructions if applicable, then remove the label. Thank you! ❤️ |
🎉 This PR is included in version 2.1.1-alpha.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 2.1.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
All Submissions:
Changes proposed in this Pull Request:
#2387 introduced minification for built style.css files, but it didn't make the theme description comment blocks important with a
/*!
prefix for child themes. Without the theme descriptions, release CI jobs fail.This PR adds the important prefixes to all theme description SCSS, and also updates some outdated description args such as supported WP versions, and removing the AMP tag.
How to test the changes in this Pull Request:
npm run build
newspack-*/style.css
built file, confirm that the theme description block appears at the top of the file. It should look like this:Other information: